Conversation
…ct retention (#131) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/666218ea-c116-4cb1-ab5c-4388b28acdc9 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Copilot Request
ci: remove disabled Apr 13, 2026
logs-token-check job, standardize artifact retention
pelikhan
deleted the
copilot/fix-9919-1036865607-81baaaa5-52c7-4d32-ad79-735fa9e8eff7
branch
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up the main CI workflow by removing a permanently-disabled job and aligning the dependency-audit artifact retention with the workflow’s common default.
Changes:
- Remove the
logs-token-checkjob (it was gated byif: falseand never executed). - Change the
dependency-auditartifactretention-daysfrom 30 to 14.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yml |
Removes dead CI job and standardizes dependency-audit artifact retention. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
1359
to
1367
| - name: Upload audit results | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 | ||
| with: | ||
| name: dependency-audit | ||
| path: | | ||
| audit.json | ||
| audit_output.txt | ||
| retention-days: 30 | ||
| retention-days: 14 | ||
|
|
There was a problem hiding this comment.
The PR description says changing dependency-audit to 14 days matches "every other artifact in the workflow", but ci.yml still has other artifact retentions (e.g., coverage-report at 7 days). If the intent is full standardization, consider aligning the remaining outliers; otherwise, please clarify the wording (or add a brief comment here explaining why this artifact is 14 while some others differ).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI cleanup identified by ci-coach analysis of 100 recent runs.
logs-token-checkjob — hadif: false, never ran, ~101 lines of noisedependency-auditartifact retention — was 30 days, now 14 to match every other artifact in the workflow